149-149: Update to line() method for position retrieval

Changed pos.row() to pos.line() to ensure consistency with the updated terminology across the codebase.

Also applies to: 153-153

57-57: Update range keys from row to line

Modified the range parameter to use "line" instead of "row", aligning with the updated API specification.

19-19: Rename attribute row to line in PosRule

Updated the PosRule class attribute from row to line to standardize terminology across the codebase.

Ensure that all references to PosRule.row have been updated to PosRule.line throughout the codebase.

Run the following script to verify:

#!/bin/bash
# Description: Find any usages of 'PosRule.row' in the codebase.

# Test: Search for 'PosRule.row' references. Expect: No results.
rg 'PosRule\.row\b'

#!/bin/bash
# Let's first verify if PosRule exists and check its current implementation
ast-grep --pattern 'class PosRule'

# Also search for any references to PosRule to understand its usage
rg 'PosRule' -A 2

#!/bin/bash
# Let's check the git history to see if there was a recent change from 'row' to 'line'
git log -p --grep="row" -- crates/pyo3/ast_grep_py/__init__.py

# Also let's check for any historical references to 'row' in this file
git grep 'row' $(git rev-list --all) -- crates/pyo3/ast_grep_py/__init__.py

64-64: LGTM! Method calls updated consistently.

The change from row() to line() is applied consistently while preserving the type conversion to u32.

Also applies to: 68-68

8-9: LGTM! Documentation and field name updated consistently.

The renaming from row to line has been properly implemented, with documentation updated to reflect the change.

97-98: LGTM! Method calls updated consistently.

The change from row() to line() is consistent with the PR objectives and maintains the same functionality.

Line range hint 20-23: LGTM! New macro follows existing patterns.

The Diffs! macro is implemented consistently with the existing Matches! macro pattern.

Line range hint 21-27: LGTM! Suppression line calculation updated consistently.

The change from row() to line() is properly implemented in the suppression collection logic, maintaining the same functionality.

Line range hint 42-46: LGTM! Suppression checking updated consistently.

The change from row() to line() is properly implemented in the suppression checking logic.

85-85: LGTM! Consistent renaming from row() to line()

The changes align with the PR objective of standardizing terminology from "row" to "line". The modifications maintain the same functionality while improving API consistency.

Let's verify that all occurrences of row() have been replaced:

Also applies to: 177-177, 196-196

#!/bin/bash
# Description: Check for any remaining instances of row() method calls
# Expect: No matches as all should be renamed to line()

rg "\.row\(\)" 

#!/bin/bash
# Let's check the context of these remaining row() calls to understand if they need to be updated

# Check debug_query.rs
echo "=== debug_query.rs ==="
rg -B 2 -A 2 "\.row\(\)" crates/cli/src/utils/debug_query.rs

# Check node.rs
echo -e "\n=== node.rs ==="
rg -B 2 -A 2 "\.row\(\)" crates/core/src/node.rs

# Let's also check if there are any line() methods in these files
# to see if there's an ongoing pattern of conversion
echo -e "\n=== Checking line() usage in the same files ==="
rg "\.line\(\)" crates/cli/src/utils/debug_query.rs crates/core/src/node.rs

#!/bin/bash
# Let's check the tree-sitter API documentation by looking at imports and type definitions
# to understand if these are different APIs

# Check tree-sitter imports and types
echo "=== Checking tree-sitter imports ==="
rg "use tree_sitter" -A 3 crates/cli/src/utils/debug_query.rs crates/core/src/node.rs

# Check Point type usage and definition
echo -e "\n=== Checking Point type usage ==="
rg "Point" -B 1 -A 1 crates/cli/src/utils/debug_query.rs crates/core/src/node.rs

45-45: LGTM! Updated position conversion to use line()

The change correctly updates the position conversion to use line() instead of row(), maintaining consistency with the new terminology.

270-270: LGTM: Consistent terminology change from row to line.

The changes correctly replace row() with line() in the MatchMerger struct, maintaining the same functionality while standardizing terminology.

Let's verify no instances of row remain in this file:

Also applies to: 299-299

#!/bin/bash
# Description: Check for any remaining instances of 'row' that might need updating
rg '\brow\b' --type rust

#!/bin/bash
# Let's check the specific file mentioned in the review comment for any 'row' instances
rg '\brow\b' 'crates/cli/src/print/colored_print.rs'

# Also let's check for any remaining instances of 'row()' method calls
rg '\.row\(\)' 'crates/cli/src/print/colored_print.rs'

13-13: Documentation correctly updated to use "line" terminology.

The documentation has been properly updated to reflect the terminology change from "row" to "line".

Also applies to: 18-19

27-27: Constructor and accessor methods updated consistently.

The Position struct's constructor and accessor methods have been updated to use "line" terminology consistently:

• Constructor parameter renamed from row to line
• Field renamed from row to line
• Accessor method renamed from row() to line()

Also applies to: 29-35

44-44: Tree-sitter Point conversion updated.

The ts_point method has been updated to use the line field instead of row.

293-293: Display context calculation updated.

The DisplayContext struct's start_line calculation has been updated to use line() instead of row().

18-19: Verify impact of breaking changes.

This is a breaking change that renames the public API from row to line. While the changes look correct, we should verify the impact on dependent code.

Let's check for any external usage of the old row API:

Also applies to: 27-27, 34-35