test: add test for unicode range test by HerringtonDarkholme · Pull Request #1630 · ast-grep/ast-grep

HerringtonDarkholme · 2024-11-30T01:54:01Z

part of #1594

Summary by CodeRabbit

Tests
- Added new test cases for validating node positions with ASCII and Unicode characters.
- Enhanced the test_unicode function to assert the line number of the node's range.

part of #1594

coderabbitai · 2024-11-30T01:54:08Z

Walkthrough

The pull request introduces new test cases in the crates/core/src/node.rs file to validate the start and end positions of nodes for ASCII and Unicode characters. Specifically, it adds the test_ascii_pos and test_unicode_pos functions. Additionally, modifications are made to the test_unicode function in crates/pyo3/tests/test_range.py, which now includes an assertion for the line number of the node's range. These changes aim to enhance the testing coverage of node position functionalities.

Changes

File Path	Change Summary
crates/core/src/node.rs	Added new test functions: `test_ascii_pos()` and `test_unicode_pos()`.
crates/pyo3/tests/test_range.py	Modified `test_unicode` to include a new assertion for the start line number of the node's range.

Possibly related PRs

feat: return char offset in pyo3 API #1178: The changes in this PR involve modifications to the handling of character offsets in the pyo3 crate, which is relevant to the new test cases added in the main PR that validate the start and end positions of nodes for both ASCII and Unicode characters.

Poem

🐇 In the code where rabbits play,
New tests hop in, brightening the day.
ASCII and Unicode, side by side,
Validating positions, with joy and pride.
Let's celebrate with a leap and a cheer,
For every character, we hold so dear! 🥳

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

crates/pyo3/tests/test_range.py (1)
51-52: Uncomment and fix the column assertion

The TODO comment is correct - the column should indeed be 5 in character count:

"ハロ" (2 characters) + " = " (3 characters) = 5 characters total

Would you like me to:

Investigate why the column assertion is failing?

Open an issue to track this character-vs-byte position discrepancy?

Here's the suggested fix:
-    # TODO: Fix this, it should be 5 in character
-    # assert node.range().start.column == 5
+    assert node.range().start.column == 5  # 2 chars (ハロ) + 3 chars ( = )

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 97451d8 and 27e34c6.

📒 Files selected for processing (2)

crates/core/src/node.rs (1 hunks)
crates/pyo3/tests/test_range.py (1 hunks)

🔇 Additional comments (2)

crates/pyo3/tests/test_range.py (1)

49-50: LGTM! The index and line assertions are correct.

The assertions correctly verify that:

start.index == 5 matches the byte position after "ハロ = "
start.line == 0 correctly identifies the first line

crates/core/src/node.rs (1)

701-708: LGTM! Well-structured test for ASCII character positions.

The test correctly validates the start and end positions for a single ASCII character, which serves as a good baseline test case.

crates/core/src/node.rs

codecov · 2024-11-30T01:56:38Z

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.99%. Comparing base (97451d8) to head (27e34c6).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/core/src/node.rs	50.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
- Coverage   87.03%   86.99%   -0.04%     
==========================================
  Files          95       95              
  Lines       15277    15291      +14     
==========================================
+ Hits        13296    13303       +7     
- Misses       1981     1988       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test: add test for unicode range test

27e34c6

part of #1594

coderabbitai bot reviewed Nov 30, 2024

View reviewed changes

crates/core/src/node.rs Show resolved Hide resolved

HerringtonDarkholme added this pull request to the merge queue Nov 30, 2024

Merged via the queue into main with commit 483215f Nov 30, 2024

HerringtonDarkholme deleted the fix-range branch November 30, 2024 02:29

coderabbitai bot mentioned this pull request Dec 1, 2024

feat: support character based column number #1634

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: add test for unicode range test#1630

test: add test for unicode range test#1630
HerringtonDarkholme merged 1 commit intomainfrom
fix-range

HerringtonDarkholme commented Nov 30, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Nov 30, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

codecov bot commented Nov 30, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

HerringtonDarkholme commented Nov 30, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Nov 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

HerringtonDarkholme commented Nov 30, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Nov 30, 2024 •

edited

Loading