Files that changed from the base of the PR and between 563357f and d62f28f.

• crates/cli/src/run.rs (3 hunks)
• crates/cli/src/scan.rs (2 hunks)
• crates/cli/src/utils/args.rs (2 hunks)
• crates/cli/src/utils/mod.rs (1 hunks)
• crates/cli/src/utils/tracing.rs (3 hunks)

crates/cli/src/utils/mod.rs (1)

10-10: LGTM! Verify the Tracing implementation.

The addition of Tracing to the public exports is consistent with the PR objective of adding tracing to the CLI argument. This change makes the Tracing item accessible to other parts of the CLI, which is likely the intended behavior.

To ensure the Tracing implementation is complete and consistent, please run the following script:

This script will help verify that Tracing is properly implemented and used within the project.

✅ Verification successful

Verified the Tracing implementation as an enum with no recursive dependencies.

The Tracing enum is correctly implemented without any unintended recursive fields, ensuring no cyclic dependencies are present. This change aligns with the PR objectives and maintains the integrity of the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the Tracing implementation and its usage

# Test 1: Check if Tracing is implemented in the tracing module
echo "Checking Tracing implementation:"
ast-grep --lang rust --pattern 'struct Tracing { $$$1 }' crates/cli/src/utils/tracing.rs

# Test 2: Look for usages of Tracing in other files
echo "Checking Tracing usage:"
rg --type rust '\bTracing\b' crates/cli

Length of output: 624

---

Script:

#!/bin/bash
# Description: Verify the Tracing implementation as an enum and check for recursive fields

# Test 1: Check if Tracing is implemented as an enum in the tracing module
echo "Checking if Tracing is an enum:"
ast-grep --lang rust --pattern 'enum Tracing { $$$1 }' crates/cli/src/utils/tracing.rs

# Test 2: Look for recursive usage of Tracing within its own implementation
echo "Checking for recursive Tracing fields:"
ast-grep --lang rust --pattern 'impl Tracing { $$$ }' crates/cli/src/utils/tracing.rs | rg 'level:\s*Tracing'

# Test 3: Look for usages of Tracing in other files to ensure proper implementation
echo "Checking Tracing usage in the codebase:"
rg --type rust '\bTracing\b' crates/cli

Length of output: 851

---

Script:

#!/bin/bash
# Description: Verify the Tracing implementation as an enum and ensure no unintended recursive dependencies

# Test 1: Check if Tracing is implemented as an enum in the tracing module
echo "Checking if Tracing is an enum:"
ast-grep --lang rust --pattern 'enum Tracing { $$$1 }' crates/cli/src/utils/tracing.rs

# Test 2: Verify that the Tracing enum does not have unintended recursive fields
echo "Verifying Tracing enum fields for unintended recursion:"
ast-grep --lang rust --pattern 'pub level: Tracing,' crates/cli/src/utils/tracing.rs

Length of output: 714

---

Script:

#!/bin/bash
# Description: Refine verification of the Tracing enum for recursive fields

# Test 1: Confirm Tracing is an enum
echo "Re-confirming if Tracing is an enum:"
ast-grep --lang rust --pattern 'enum Tracing { $$$1 }' crates/cli/src/utils/tracing.rs

# Test 2: Refined pattern to check for recursive field within the Tracing enum
echo "Verifying Tracing enum fields for recursive dependencies with refined pattern:"
ast-grep --lang rust --pattern 'enum Tracing {
    $$$
    pub\s+level\s*:\s*Tracing,
    $$$
}' crates/cli/src/utils/tracing.rs

Length of output: 469

crates/cli/src/utils/args.rs (1)

4-4: LGTM: New import for Tracing

The added import for Tracing is correctly placed and follows the existing import style in the file. This import is necessary for the new tracing field in the OutputArgs struct.

crates/cli/src/scan.rs (3)

Line range hint 1-394: Summary: Tracing functionality successfully integrated into the scanning process.

The changes in this file successfully implement the PR objective of adding tracing to CLI arguments. The modifications include:

1. Adding a tracing field to the OutputArgs struct.
2. Integrating tracing into the ScanWithConfig::try_new method for statistics management.
3. Updating the Worker implementation to print tracing statistics after processing items.

These changes enhance the scanning process by providing additional tracing capabilities without disrupting the existing functionality. The implementation appears consistent and well-integrated into the codebase.

To ensure the robustness of these changes, consider adding unit tests specifically for the new tracing functionality, including edge cases and different configuration scenarios.

---

Line range hint 165-165: LGTM! Verify the implementation of the print method for ScanStats.

The addition of eprintln!("{}", self.stats.print()); ensures that the tracing statistics are reported at the end of the scanning process. This change completes the integration of tracing functionality into the scanning workflow.

To ensure the correct implementation of the print method for ScanStats, please run the following verification script:

#!/bin/bash
# Description: Verify the implementation of the print method for ScanStats.

# Test: Search for the print method definition in ScanStats
rg --type rust -g '!target/' 'impl.*ScanStats.*fn\s+print.*\('

# Test: Check for any unit tests related to ScanStats print method
rg --type rust -g '!target/' '#\[test\].*fn.*scan_stats.*print'

---

122-122: LGTM! Verify the implementation of scan_stats method.

The change to use arg.output.tracing.scan_stats(rule_stats) for initializing the stats field integrates the new tracing functionality into the scanning process. This modification aligns with the PR objective and enhances the statistics management capabilities.

To ensure the correct implementation of the scan_stats method, please run the following verification script:

Also applies to: 127-127

crates/cli/src/run.rs (3)

201-205: LGTM: Enhanced statistics tracking for RunWithInferredLang

The addition of the stats field initialized with arg.output.tracing.run_stats() improves the capability to track runtime statistics for the RunWithInferredLang struct. This change aligns well with the overall goal of enhancing statistics management during execution.

---

290-296: LGTM: Consistent statistics tracking for RunWithSpecificLang

The addition of the stats field initialized with arg.output.tracing.run_stats() for the RunWithSpecificLang struct maintains consistency with the previous change for RunWithInferredLang. This ensures uniform statistics tracking across different run modes, enhancing the overall capability to monitor runtime performance.

---

404-405: LGTM: Completed tracing feature with default initialization

The addition of the tracing: Default::default() field to the OutputArgs struct in the default_run_arg() function completes the implementation of the tracing feature. This ensures that the new tracing field is properly initialized with its default value when creating a default RunArg, maintaining consistency with the rest of the implementation.

crates/cli/src/utils/tracing.rs (3)

21-27: LGTM! Tracing enum modifications are appropriate

The addition of the Nothing variant with the #[default] attribute correctly sets the default tracing level. Deriving Default, Serialize, and Deserialize on the Tracing enum enhances its usability for default instantiation and serialization purposes.

---

33-48: LGTM! Added methods run_stats and scan_stats are correctly implemented

The run_stats and scan_stats methods provide convenient ways to initialize RunStats and ScanStats with the current tracing level and default values. The implementation is clean and aligns with the design patterns of the codebase.

---

93-96: LGTM! RuleStats struct modifications are appropriate

The RuleStats struct correctly derives Default, Serialize, and Deserialize. Removing the Debug derive is acceptable if it's not needed for debugging purposes.