Use Hunter for pulling in dependencies #2488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9dd509 to
7de92ca
Compare
7de92ca to
b36cd33
Compare
b36cd33 to
d00f4f4
Compare
Contributor
Author
|
@kimkulling Any thoughts on this? |
Member
|
For me it looks fine as a prototype test, which could get enabled on master. I also played around with Conan, but there aren't any working results out there until now. Let me do the code review and then I will merge it, if no one else has any concerns. |
|
Few notes from myself. Personally, I don’t update my assimp version as much as I should. Namely because when I do, I have to (re)build it so many times for so many different systems. iOS, Android, Windows store (arm,x86,x64), mac, windows desktop, etc. So, I’m on board with a new dependency manager as long as it doesn’t impede my ability to use CMake to build assimp again for the above systems. Just my two cents. |
Member
|
Merged, let's see! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assimp has a lot of dependencies, copied into the repo at
contrib/. The Hunter package manager (https://github.com/ruslo/hunter) helps manage such a dependency tree, as well as potential integration into other projects.As mentioned in #1946, there is a fork of Assimp in Hunter but it is quite dated: https://github.com/hunter-packages/assimp.
This PR adds support for the Hunter package manager in Assimp, using it to resolve and pull in dependencies only when the
HUNTER_ENABLEDCMake argument is set. By default,HUNTER_ENABLEDis set toOFFand the current CMake behavior is preserved.This PR does a few things besides adding the requisite Hunter-related CMake files if
HUNTER_ENABLED=ON:-std=cxx11and-fPIC) as they will be set externallyASSIMP_USE_HUNTERand rewrite include paths for dependencies if setWhat's missing:
Open3DGC - I haven't added this to Hunter and disabled it in Assimp for Hunter builds. For glTF 2.0, perhaps Draco is more widely supported and I have added that to Hunter so it would be pretty easy to add to Assimp.
Testing of tools/samples/tests - I focused on incorporating the library build for use in the package manager.
As a sanity check, I was able to build the library after completely removing the
contrib/directory.