fuzz: Fix memory leak in ForceFormat helper (#6435)

skypher · web-flow · commit 522c703bb913 · 2026-01-09T11:02:21.000+01:00
The ForceFormat function unregisters importers from the Importer
but doesn't delete them, causing memory leaks detected by ASan
during OSS-Fuzz check_build.

When UnregisterLoader is called, the importer is removed from the
internal list but the memory is not freed. Since the Importer
originally allocated these objects and we're removing them from
its management, we must delete them explicitly.

Also include BaseImporter.h to ensure complete type information
is available for proper deletion.

This fixes OSS-Fuzz check_build failures for all format-specific
fuzzers (obj, gltf, glb, fbx, collada, stl).
diff --git a/fuzz/fuzzer_common.h b/fuzz/fuzzer_common.h
@@ -41,6 +41,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #pragma once
 
 #include <assimp/Importer.hpp>
+#include <assimp/BaseImporter.h>
 #include <assimp/importerdesc.h>
 #include <cstring>
 #include <vector>
@@ -97,6 +98,7 @@ inline bool ForceFormat(Assimp::Importer& importer, const char* targetExtension)
 
     for (auto* imp : toRemove) {
         importer.UnregisterLoader(imp);
+        delete imp;  // Free the unregistered importer to prevent memory leaks
     }
 
     return found;
