-
-
Notifications
You must be signed in to change notification settings - Fork 766
Add missing module descriptor to assertj-guava, adopt module-only build
#3771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c9beba3 to
4144c91
Compare
...j-tests/assertj-integration-tests/assertj-core-tests/src/test/java/module-info.java.disabled
Show resolved
Hide resolved
845f687 to
3c8e39f
Compare
99f346a to
f6dbc5f
Compare
e8f4d48 to
09fcf7d
Compare
|
The current failures might benefit from #3185. |
670bc68 to
8fc270b
Compare
2564bfc to
56408a0
Compare
4c57861 to
49a144e
Compare
| requires org.assertj.core; | ||
| requires org.junit.jupiter.params; | ||
| requires org.junitpioneer; | ||
| requires org.mockito; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mockito 5.16.0 now ships module descriptors 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint! I'll update and let you know 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimvdLippe It seems there are some errors in our integration tests when upgrading Mockito from 5.15.2 to 5.16.0.
I'll dig a bit more and raise an issue with the details.
3f9f887 to
338a8a9
Compare
|
The culprit of the Windows failures: This is likely related to https://learn.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation, as the current command line has over 13k characters. |
2d2b045 to
c60a012
Compare
|
!!Hey @scordio I think that maybe somthing like this can work to bypass the limitation of the argLine and move it to a file: Tomorrow I can try locally, but I guess you committing and running the GHA would be easier/faster. I remember maybe something similar about length of argLines about mvnd as well, maybe @cstamas or @gnodet would know. Edit: the default approach is using |
|
Thanks for the suggestions, @lobaorn! I'll try them and see how they cooperate with the IDE, as IDE out-of-the-box support is the big advantage of the current |
c60a012 to
fb5f4d2
Compare
| --add-opens=java.base/java.math=ALL-UNNAMED | ||
| --add-opens=java.base/java.util=ALL-UNNAMED | ||
| --add-opens=java.base/sun.nio.fs=ALL-UNNAMED | ||
| @${project.basedir}/argFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos to @lobaorn and @sormuras – this seems to play nicely with both Maven and the IDE when on Windows 🙂
Reference: https://docs.oracle.com/en/java/javase/21/docs/specs/man/java.html#java-command-line-argument-files
I hope you don't mind being mentioned as co-authors when I finally merge this PR 😉
|
When working on #3442, I forgot to upgrade Mockito to version 5 in |
aea8523 to
5818678
Compare
Deliverables
assertj-coreassertj-guavaassertj-testsmodules exceptassertj-core-spring-bootassertj-core-spring-bootremains on classpath testing due to the lack of module system support by some Spring Boot transitive dependencies