-
-
Notifications
You must be signed in to change notification settings - Fork 766
Add doesNot[Start/End]WithWhitespace methods to CharSequence assertions
#3441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can't we use CharSequence#codePoints()? |
|
Thanks for better method. I'll fix it right now. |
|
@onacit why would using code points be better than char to detect whitespaces ? |
|
@joel-costigliola As documented in Character.isWhitespace(char), it'll, I think, be better when we use codePoints.
Thanks. |
Best would be to compose a test that demonstrates the need for The test would also prevent regressions if we changed the implementation to Taking inspiration from https://stackoverflow.com/a/18169122/9714611, maybe a value from this list could help? |
|
I'm on it @scordio ! @yyytir777 you'll get full credit for the PR don't worry :) |
|
Integrated thanks @yyytir777 ! |
doesNot[Start/End]WithWhitespace methods to CharSequence assertions
Check List: