-
-
Notifications
You must be signed in to change notification settings - Fork 766
Add doesNotContainKey and doesNotContainKeys to Guava Multimap assertions
#3334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ass to match those for java.util maps
|
Thanks @ryber, we will review your PR shortly ! |
assertj-guava/src/test/java/org/assertj/guava/api/MultimapAssert_doesNotContainKeys_Test.java
Outdated
Show resolved
Hide resolved
assertj-guava/src/main/java/org/assertj/guava/api/MultimapAssert.java
Outdated
Show resolved
Hide resolved
|
Thanks @ryber, first round of code review done, mostly minor stuff ;-) |
|
@joel-costigliola feedback pushed up on its own commit. If you would rather I squash them and force push to the branch I can, or you can squash on merge, or you can leave them as different commits of course. I was not sure what your preference was. I think I got everything 😄 |
|
We usually squash the commits into one to make logical commits, cool if you do it but no problem if you let us |
assertj-guava/src/main/java/org/assertj/guava/api/MultimapAssert.java
Outdated
Show resolved
Hide resolved
assertj-guava/src/main/java/org/assertj/guava/api/MultimapAssert.java
Outdated
Show resolved
Hide resolved
|
thanks @scordio updated with feedback applied |
|
Thanks for your first contribution, @ryber! We'll go ahead with the merge after releasing 3.25.2 (expected later this month). |
|
@scordio oh sorry! I didn't catch that you suggested a name change. I went ahead and changed it |
doesNotContainKey and doesNotContainKeys to Guava Multimap assertions
|
Thanks for your first contribution, @ryber! |
Behavior matches the asserts for regular java.util Map asserts in core.