Skip to content

Add assertions for JDK YearMonth type #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmvlpl wants to merge 1 commit into from
Closed

Add assertions for JDK YearMonth type #3142

tmvlpl wants to merge 1 commit into from

Conversation

@tmvlpl
Copy link
Contributor

@tmvlpl tmvlpl commented Aug 6, 2023 •
edited
Loading

Check List:

This PR adds assertions for the java.time.YearMonth type. I have based the new assertions on the existing LocalDate assertions. Therefore they should contain similar/matching assertions except for the following differences:

  • no hasDayOfMonth assertion
  • no isToday assertion
  • an isCurrentYearMonth assertion

I hope I found and extended all the right entry points.

@tmvlpl tmvlpl force-pushed the year-month-assertions branch from b0b5f80 to c24454d Compare August 6, 2023 20:44
@tmvlpl
Copy link
Contributor Author

tmvlpl commented Aug 14, 2023

I'm wondering if there is anything I can do in light of the failing pitest check, although it seems to be related to some license issue?

@scordio
Copy link
Member

scordio commented Aug 15, 2023

Nothing to be done, @tmvlpl, and yes, it's a license issue (see #3140).

@tmvlpl tmvlpl force-pushed the year-month-assertions branch from c24454d to 529f6e6 Compare September 24, 2023 19:01
@tmvlpl tmvlpl force-pushed the year-month-assertions branch 2 times, most recently from 00429b0 to 80e7c81 Compare December 17, 2023 20:34
@goughy000
Copy link
Contributor

goughy000 commented Jan 23, 2024

Hey this looks great - looks like the PR has been open a while though. @scordio - do you know if there's anything outstanding before the team can get this merged and released?

@scordio
Copy link
Member

scordio commented Jan 24, 2024

@goughy000 we'll need to review the changes so it's mostly a matter of time 🙂 I'll add it to the 3.26.0 milestone.

@scordio scordio added this to the 3.26.0 milestone Jan 24, 2024
@tmvlpl
Copy link
Contributor Author

tmvlpl commented Jan 25, 2024

The 3.25.0 release added isInThePast and isInTheFuture to the missing Java 8 date/time types. These could be added for YearMonth too. I can try to rebase the branch this weekend and add the two new assertions.

@tmvlpl tmvlpl force-pushed the year-month-assertions branch from 80e7c81 to 5f93909 Compare January 30, 2024 19:19
@tmvlpl
Copy link
Contributor Author

tmvlpl commented Jan 30, 2024

The PR already contained the two new methods. So I only rebased it and updated the Javadoc tags.

@joel-costigliola
Copy link
Member

joel-costigliola commented Mar 10, 2024

Integrated thanks @tmvlpl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.26.0

Development

Successfully merging this pull request may close these issues.

Assertions for JDK YearMonth Type

4 participants

@tmvlpl @scordio @goughy000 @joel-costigliola