Add isRecord and isNotRecord to Class assertions
#2968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @ljrmorgan, this one is better targeted to assertj 4.0 which will use java 17 |
Contributor
Author
|
Thanks @joel-costigliola! A Java 17 baseline would also remove all the reflection code, which would be great. Is there a |
scordio
reviewed
Feb 28, 2023
assertj-core/src/main/java/org/assertj/core/api/AbstractClassAssert.java
Outdated
Show resolved
Hide resolved
assertj-core/src/main/java/org/assertj/core/api/AbstractClassAssert.java
Outdated
Show resolved
Hide resolved
assertj-core/src/main/java/org/assertj/core/internal/Classes.java
Outdated
Show resolved
Hide resolved
assertj-core/src/main/java/org/assertj/core/internal/Classes.java
Outdated
Show resolved
Hide resolved
assertj-core/src/test/java/org/assertj/core/api/classes/ClassAssert_isRecord_Test.java
Outdated
Show resolved
Hide resolved
Member
Not yet but as I mentioned I still think we could ship this in 3.x and change the implementation in 4.x. @joel-costigliola how do you see it? |
Member
|
I can live with that |
3f2c240 to
ab770d6
Compare
Member
|
Thanks for your first contribution, @ljrmorgan! |
isRecord and isNotRecord to Class assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List:
Add
isRecord()andisNotRecord()Class assertions.As
recordonly landed in Java 16 I'm having to use reflection to check whether the class is a record or not. I'm also only able to add unit tests for the negative cases, because I can't compile code that usesrecord.If this is accepted I thought I'd also open a PR that adds a
hasRecordComponentsassertion.