Skip to content

Add "it" infrastructure for integration tests #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sormuras wants to merge 4 commits into from
Closed

Add "it" infrastructure for integration tests #1778

sormuras wants to merge 4 commits into from

Conversation

@sormuras
Copy link
Contributor

@sormuras sormuras commented Feb 6, 2020

This PR adds an optional maven-invoker-plugin based profile to the build configuration that builds a set of Maven projects located in the newly added "src/it" directory.

No dedicated verification script is evaluated after such an "it" project build for the time being. A successful build is considered as successful test case.

@sormuras sormuras force-pushed the add-integration-tests branch from f9cae1f to 33ad627 Compare February 6, 2020 16:58
@sormuras sormuras mentioned this pull request Feb 6, 2020
Closed
3 tasks
@sormuras sormuras marked this pull request as ready for review February 6, 2020 22:28
@sormuras
Copy link
Contributor Author

sormuras commented Feb 6, 2020 •
edited
Loading

Done

  • Wait for new release of Byte Buddy, with raphw/byte-buddy@d9a5b3a included.
  • Depend on and shade that new Byte Buddy release.
  • Revert 7530a14 and verify all "its" are still green

@joel-costigliola joel-costigliola mentioned this pull request Feb 17, 2020
Merged
@scordio
Copy link
Member

scordio commented Feb 18, 2020

@sormuras new release just merged in 71dc3ff

@sormuras
Copy link
Contributor Author

sormuras commented Feb 18, 2020

Alright. Will perform the pending tasks today.

@sormuras
Add "it" infrastructure for integration tests
c8b2b27 
This commit adds an optional maven-invoker-plugin based profile
to the build configuration that builds a set of Maven projects
located in the newly added "src/it" directory.

No dedicated verification script is evaluated after such an
"it" project build for the time being. A successful build is
considered as successful test case.
@sormuras
Show failing integration test
f2585b7 
This "it" project runs tests on the module path,
using AssertJ's SoftAssertions utility. As no module
declares a read edge to module "java.instrument", the
build of this "it" project fails.

Issue: assertj#1711
@sormuras
Fix failing integration test on the command line
f6b0cd0 
This commit inserts the required command line options and
arguments to successfully execute the test on the module
path for the time being.

Note: An update of the Byte Buddy library should have the
same effect. According to @raphw ;-)
@sormuras
Revert 7530a14 and verify all "its" are still green
4fe5097
@sormuras sormuras force-pushed the add-integration-tests branch from e9ef813 to 4fe5097 Compare February 18, 2020 07:29
@sormuras
Copy link
Contributor Author

sormuras commented Feb 18, 2020 •
edited
Loading

Let's see what the CI run says...
It reported: ✔️
Link: https://github.com/joel-costigliola/assertj-core/runs/452138054#step:4:6923

Note: I had trouble using the maven-surefire-plugin to get tests run on the module-path. Therefore, I switched to an external JUnit Platform launching plugin named junit-platform-maven-plugin for the time being. As I actively maintain the latter and listen closely to changes/fixes applied to the former, I'll be able to switch back to the maven-surefire-plugin a) if possible and b) if wanted.

@joel-costigliola joel-costigliola changed the base branch from master to main June 21, 2020 05:33
@sormuras
Copy link
Contributor Author

sormuras commented Oct 27, 2021

I see an "it" was added on main branch: https://github.com/assertj/assertj-core/tree/main/src/it

Are you still interested in adding a module-based integration test project?

@scordio scordio self-assigned this Oct 27, 2021
@joel-costigliola
Copy link
Member

joel-costigliola commented Oct 27, 2021

@sormuras we are!
We have been discussing it with the team lately and we feel these kind of tests would be better run from assertj-examples but before that we would need to make a maven multi module project so that we build the different assertj projects in one go - still pondering the best approach here. @scordio might give more details, he's the brain behing this idea 😉

@scordio
Copy link
Member

scordio commented Aug 31, 2022

Hey @sormuras! I'm finally getting back to your PR.

This one is most likely superseded by #2759 mostly because of IDE friendliness, although I've just hit a fancy issue with IDEA.

@scordio scordio mentioned this pull request Aug 31, 2022
Closed
@scordio scordio added type: enhancement theme: module system An issue related to the Java module system labels Aug 31, 2022
@sormuras
Copy link
Contributor Author

sormuras commented Sep 1, 2022

What is "JPMS"? I am only aware of "Java modules". (-:

@scordio
Copy link
Member

scordio commented Sep 1, 2022

What is "JPMS"? I am only aware of "Java modules". (-:

It's a weird acronym I read on a blog 😀

@sormuras
Copy link
Contributor Author

sormuras commented Sep 1, 2022

On topic: feel free to close this superseded pull request.

@scordio
Copy link
Member

scordio commented Sep 1, 2022

What is "JPMS"? I am only aware of "Java modules". (-:

Who said JPMS? I obviously said module path 🙂

@sormuras
Copy link
Contributor Author

sormuras commented Sep 1, 2022 •
edited
Loading

It's a weird acronym I read on a blog 😀

There is no spoon. And there is no JPMS in the blog either... 🤓

@scordio
Copy link
Member

scordio commented Sep 1, 2022

There is no spoon. And there is no JPMS in the blog either... 🤓

I've already taken the red pill, so I see how deep the rabbit hole goes...

@scordio
Copy link
Member

scordio commented Oct 18, 2022 •
edited
Loading

Superseded by #2759 / #2773.

@scordio scordio closed this Oct 18, 2022
@scordio scordio added the status: superseded An issue that has been superseded by another label Oct 18, 2022
@sormuras sormuras deleted the add-integration-tests branch March 5, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@scordio scordio

Labels

status: superseded An issue that has been superseded by another theme: module system An issue related to the Java module system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sormuras @scordio @joel-costigliola