Skip to content

Align javadoc CSS to java 12 default, add CSS minification#1600

Merged
joel-costigliola merged 1 commit intomasterfrom
javadoc_anchor_links
Sep 8, 2019
Merged

Align javadoc CSS to java 12 default, add CSS minification#1600
joel-costigliola merged 1 commit intomasterfrom
javadoc_anchor_links

Conversation

@scordio
Copy link
Member

@scordio scordio commented Sep 8, 2019

Should hopefully fix #1570!

Also bumped highlight.js to version 9.15.10.

@joel-costigliola
Copy link
Member

Wow, how did find what the cause was ?

@joel-costigliola
Copy link
Member

I'm merging it and generate the javadoc when I'll get back home to see if it fixes the issue, thanks!

@joel-costigliola joel-costigliola merged commit 58290b1 into master Sep 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the javadoc_anchor_links branch September 8, 2019 23:39
@scordio
Copy link
Member Author

scordio commented Sep 9, 2019

Wow, how did find what the cause was ?

I stumbled upon this page and I started to play with the maven plugin, discovering that without the stylesheet parameter it was able to generate the default stylesheet of the jdk.

Then I assumed our CSS has no customization except for highlight.js, so I combined the one from the JDK and the default from highlight.js! :-)

@joel-costigliola
Copy link
Member

The links work now :) but the CSS is kinda lost so no code highlighted likely due to that warning when I'm generating the javadoc:

[INFO] --- maven-javadoc-plugin:3.1.1:javadoc (default-cli) @ assertj-core ---
[WARNING] Unable to find the resource 'home/joel/prog/assertj/assertj-core-3.x/target/javadoc-stylesheet/assertj-javadoc-min.css'. Using default Javadoc resources.

@scordio
Copy link
Member Author

scordio commented Sep 9, 2019

I might know why, I'll check soon

@scordio
Copy link
Member Author

scordio commented Sep 9, 2019

@joel-costigliola just pushed the maven phase fix, could you try again?

@joel-costigliola
Copy link
Member

It works, awesome!
I just need to put back the railcast theme for highlight and we good.

@scordio
Copy link
Member Author

scordio commented Sep 9, 2019

Oh sorry I missed that.

@joel-costigliola
Copy link
Member

joel-costigliola commented Sep 9, 2019

Done!
image

@joel-costigliola
Copy link
Member

joel-costigliola commented Sep 9, 2019

will be 100% done when #1584 is addressed (but nothing urgent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Javadoc anchor links don't work (Java 11)

2 participants