-
-
Notifications
You must be signed in to change notification settings - Fork 765
Closed
Description
Describe the bug
There are 20+ tests failing on Windows because of using unsupported features.
- the assertion conversion is implemented in shell scripts, and the test tries to run them
- many path related tests do positive and negative testing for all kinds of assertions with a kind of variation of test cases, one or two being on symbolic links each time. As the javadoc of the symbolic link creation method states, that may fail on some systems because of missing privileges. That's the case for Windows.
I have a local change that disables these test methods (for the symbolic links) or test classes (for the conversion) on Windows and with a useful message. Would that be a reasonable fix as PR? The much harder alternative would be to recognize the IOException for the missing privileges in the tests, to verify their message and that it's Windows. I'm not a fan of such tests (and the message is localized for me, so not sure whether that even works).
Metadata
Metadata
Assignees
Labels
No labels