-
-
Notifications
You must be signed in to change notification settings - Fork 765
Open
Labels
status: team discussionAn issue we'd like to discuss as a team to make progressAn issue we'd like to discuss as a team to make progress
Description
Summary
We tests assertj core with integration tests to validate junit 4, testng and osgi integration, this works but is more a workaround to simulate different environments.
A better solution consists in defining a multi module project where junit 4 and testng checks will be done in their own modules which are closer to real project using assertj.
Modules:
- assertj-core
- assertj-guava
- assertj-db
-
assertj-joda - assertj-neo4j
- assertj-examples
- assertj-core-junit4-with-opentest4j and remove the corresponding integration tests in assertj-core
- assertj-core-junit4-with-testng and remove the corresponding integration tests in assertj-core
- assertj-core-osgi-tests and remove the corresponding integration tests in assertj-core
Github actions
We need to update our CI actions to build the multimodule project.
A commit in main should trigger all the modules build but the assertj core CI build should only reports errors when any of these modules build fail:
- assertj-core module
- assertj-core-junit4-with-opentest4j
- assertj-core-junit4-with-testng
- assertj-core-osgi-tests
The assertj core should not fail if an assertions module fails (ex: assertj-guava), this should be reported by the assertion module build itself.
Metadata
Metadata
Assignees
Labels
status: team discussionAn issue we'd like to discuss as a team to make progressAn issue we'd like to discuss as a team to make progress