Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

JS/TS client HubConnection.onClosed should be a method instead of a property #842

Closed
Closed
JS/TS client HubConnection.onClosed should be a method instead of a property#842
Labels
1 - Readytype: Enhancement
Milestone
1.0.0-alpha2
@davidfowl

Description

@davidfowl
davidfowl
opened on Sep 11, 2017

It should be possible to wire up multiple handlers to the closed event. We could even consider using on instead of having special events. That does mean we would need reserved names but it would be less concepts.

Today:

let http = new signalR.HttpConnection(document.location.protocol + '//' + document.location.host + '/chat');
let connection = new signalR.HubConnection(http);

connection.onClosed = e => {
        
};

Proposal:

let http = new signalR.HttpConnection(document.location.protocol + '//' + document.location.host + '/chat');
let connection = new signalR.HubConnection(http);

connection.on('close', e => {
        
});

We could also change the nomenclature and use connect/disconnect like the server side does.

/cc @moozzyk

Metadata

Metadata

Assignees

No one assigned

    Labels

    1 - Readytype: Enhancement

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions