Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Not all request rejections are logged #1295

@cesarblum

Description

@cesarblum

BadHttpRequestExceptions caught in

are not being logged except when logged before being thrown (such as when calling Frame.RejectRequest), even though the comment in the catch block indicates that should be the case.

This is the case for requests containing invalid characters in headers (see aspnet/Mvc#5662), where the BadHttpRequestException is thrown from MemoryPoolIterator.GetAsciiString. This should be refactored BTW.

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions