Do not add IHttpContextAccessor to DI by default

pakrym · pakrym · commit 7c8b37bcc726 · 2015-11-18T15:03:03.000-08:00
diff --git a/src/Microsoft.AspNet.Hosting/WebHostBuilder.cs b/src/Microsoft.AspNet.Hosting/WebHostBuilder.cs
@@ -75,7 +75,6 @@ private IServiceCollection BuildHostingServices()
             services.AddTransient<IServerLoader, ServerLoader>();
             services.AddTransient<IApplicationBuilderFactory, ApplicationBuilderFactory>();
             services.AddTransient<IHttpContextFactory, HttpContextFactory>();
-            services.AddSingleton<IHttpContextAccessor, HttpContextAccessor>();
             services.AddLogging();
 
             var diagnosticSource = new DiagnosticListener("Microsoft.AspNet");
diff --git a/test/Microsoft.AspNet.TestHost.Tests/TestServerTests.cs b/test/Microsoft.AspNet.TestHost.Tests/TestServerTests.cs
@@ -13,6 +13,7 @@
 using Microsoft.AspNet.Http;
 using Microsoft.AspNet.Http.Features;
 using Microsoft.AspNet.Http.Features.Internal;
+using Microsoft.AspNet.Http.Internal;
 using Microsoft.AspNet.Testing.xunit;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
@@ -289,14 +290,18 @@ public async Task CanAccessLogger()
         [Fact]
         public async Task CanAccessHttpContext()
         {
+            Action<IServiceCollection> configureServices = services =>
+            {
+                services.AddSingleton<IHttpContextAccessor, HttpContextAccessor>();
+            };
             TestServer server = TestServer.Create(app =>
             {
                 app.Run(context =>
                 {
                     var accessor = app.ApplicationServices.GetRequiredService<IHttpContextAccessor>();
                     return context.Response.WriteAsync("HasContext:"+(accessor.HttpContext != null));
                 });
-            });
+            }, configureServices);
 
             string result = await server.CreateClient().GetStringAsync("/path");
             Assert.Equal("HasContext:True", result);
@@ -315,15 +320,19 @@ public ContextHolder(IHttpContextAccessor accessor)
         [Fact]
         public async Task CanAddNewHostServices()
         {
+            Action<IServiceCollection> configureServices = services =>
+            {
+                services.AddSingleton<IHttpContextAccessor, HttpContextAccessor>();
+                services.AddSingleton<ContextHolder>();
+            };
             TestServer server = TestServer.Create(app =>
             {
                 app.Run(context =>
                 {
                     var accessor = app.ApplicationServices.GetRequiredService<ContextHolder>();
                     return context.Response.WriteAsync("HasContext:" + (accessor.Accessor.HttpContext != null));
                 });
-            },
-            services => services.AddSingleton<ContextHolder>());
+            }, configureServices);
 
             string result = await server.CreateClient().GetStringAsync("/path");
             Assert.Equal("HasContext:True", result);
