[Caching] remove implicit cast from CachedWord to Word (1.7%)#1607
Merged
sebastienros merged 3 commits intoaspnet:masterfrom Nov 30, 2020
Merged
[Caching] remove implicit cast from CachedWord to Word (1.7%)#1607sebastienros merged 3 commits intoaspnet:masterfrom
sebastienros merged 3 commits intoaspnet:masterfrom
Conversation
Contributor
adamsitnik
commented
Nov 27, 2020
| load | before | after |
|---|---|---|
| CPU Usage (%) | 22 | 22 |
| Cores usage (%) | 605 | 615 |
| Working Set (MB) | 48 | 48 |
| Build Time (ms) | 3,733 | 3,973 |
| Start Time (ms) | 0 | 0 |
| Published Size (KB) | 76,401 | 76,401 |
| First Request (ms) | 67 | 66 |
| Requests/sec | 268,293 | 272,573 |
| Requests | 4,051,004 | 4,115,679 |
| Mean latency (ms) | 1.11 | 1.11 |
| Max latency (ms) | 41.51 | 42.72 |
| Bad responses | 0 | 0 |
| Socket errors | 0 | 0 |
| Read throughput (MB/s) | 844.32 | 857.79 |
| Latency 50th (ms) | 0.93 | 0.91 |
| Latency 75th (ms) | 1.03 | 1.01 |
| Latency 90th (ms) | 1.15 | 1.14 |
| Latency 99th (ms) | 8.74 | 9.01 |
Contributor
Author
|
@sebastienros ping |
src/BenchmarksApps/Kestrel/PlatformBenchmarks/BenchmarkApplication.Caching.cs
Outdated
Show resolved
Hide resolved
src/BenchmarksApps/Kestrel/PlatformBenchmarks/Data/CachedWorld.cs
Outdated
Show resolved
Hide resolved
Member
|
I was giving @benaadams some time to comment too. |
Contributor
PR to TE? Not long left for Round 20
|
Contributor
Author
It was just 1.7% and all my MemoryCache improvements will be part of 6.0, so I think that we can skip this round for this particular benchmark. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.