Update for safe startline parsing PR#1497
Merged
sebastienros merged 2 commits intoaspnet:masterfrom Apr 28, 2020
Merged
Conversation
halter73
reviewed
Apr 24, 2020
src/BenchmarksApps/Kestrel/PlatformBenchmarks/BenchmarkApplication.HttpConnection.cs
Show resolved
Hide resolved
Member
|
@sebastienros The startline PR has been merged to master. Should we merge this now? |
halter73
approved these changes
Apr 24, 2020
…tion.HttpConnection.cs Co-Authored-By: Stephen Halter <halter73@gmail.com>
Member
|
I think it's ok as the change was in aspnet. But let me test it tomorrow first. |
Contributor
Author
|
Currently Platform tests will break when aspnet is updated? (The regular ones should be fine as is internal) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change for PR dotnet/aspnetcore#20885 (unmerged)
/cc @halter73