Merged
Conversation
rynowak
approved these changes
Jan 18, 2019
Member
Author
|
@mkArtakMSFT This should be ready. Could it be merged? The AspNetCore-ci failure is unrelated. |
Member
Author
|
@mkArtakMSFT Actually please wait. Just spotted a problem. |
rynowak
approved these changes
Jan 18, 2019
Member
rynowak
left a comment
There was a problem hiding this comment.
Cool, this looks like the fix for what I ran into while trying these out in VS. Once this is merged, I'll confirm again that it works when driven by VS.
Member
Author
|
OK, ready now. |
mkArtakMSFT
approved these changes
Jan 18, 2019
Member
Author
|
@mkArtakMSFT As usual, the AspNetCore-ci failure is unrelated, so this should be good to merge now. |
This was referenced Jan 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6826, #6824, #6827