Skip to content

feat: provide a way for individual ts_project targets to reserve extr…#569

Merged
alexeagle merged 2 commits into
mainfrom
resource_set
Jul 10, 2024
Merged

feat: provide a way for individual ts_project targets to reserve extr…#569
alexeagle merged 2 commits into
mainfrom
resource_set

Conversation

@alexeagle

@alexeagle alexeagle commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

…a RAM

Some targets are globs of a large amount of code. By default Bazel allocates only 250MB See bazelbuild/bazel@d7f0724#diff-139b184febb86269f1ceee705bde7274e2efcccaa3f435a8c6cb2f1f0854ce46R96

Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Relevant documentation has been updated

Test plan

  • New test cases added

jbedard
jbedard reviewed Mar 15, 2024
View reviewed changes
Comment thread ts/private/ts_lib.bzl Outdated
DavidZbarsky-at
DavidZbarsky-at reviewed Mar 15, 2024
View reviewed changes
Comment thread ts/private/ts_lib.bzl Outdated
@alexeagle

alexeagle commented Mar 18, 2024

Copy link
Copy Markdown
Contributor Author

Note, this isn't urgent for @DavidZbarsky-at as it's already patched there, so I'll try to land the principled thing in bazel-lib first (many of our rulesets should expose this)

@alexeagle

alexeagle commented Mar 18, 2024

Copy link
Copy Markdown
Contributor Author

Landed bazel-contrib/bazel-lib#792

This ought to depend on bazel-lib 2.0 now, but we have the usual problem that it's a breaking change. Maybe we can have a separate entry point for ts_project_with_resource_set. Or just wait for rules_ts 3.0? Or give up on our adherence to semver and just require bazel-lib 2.0 in a 2.x release of rules_ts.

@alexeagle alexeagle added this to the 3.0 milestone Apr 8, 2024
@gregmagolan gregmagolan mentioned this pull request May 6, 2024
Closed
21 tasks
@gregmagolan

gregmagolan commented May 6, 2024

Copy link
Copy Markdown
Member

Related internal thread: https://aspect-build.slack.com/archives/C05S94VJWNM/p1710536751433789?thread_ts=1710508945.458429&cid=C05S94VJWNM

@alexeagle

alexeagle commented Jul 10, 2024

Copy link
Copy Markdown
Contributor Author

now that main targets rules_ts 3.x and is guaranteed to have bazel-lib 2.x, I'm unblocked to rely on the new resource_sets helper :)

@aspect-workflows

aspect-workflows Bot commented Jul 10, 2024 •
edited
Loading

Copy link
Copy Markdown

Test

1 test target passed

Targets 
//docs:update_0_test [k8-fastbuild] 30ms

Total test execution time was 30ms. 80 tests (98.8%) were fully cached saving 12s.

Buildifier      Format

@alexeagle alexeagle merged commit acd9f4f into main Jul 10, 2024
@alexeagle alexeagle deleted the resource_set branch July 10, 2024 22:47
@fpotter fpotter mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedard jbedard jbedard approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

+1 more reviewer

@DavidZbarsky-at DavidZbarsky-at DavidZbarsky-at left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@alexeagle @gregmagolan @jbedard @DavidZbarsky-at