Skip to content

feat: upgrade to rules_js 2.0#253

Merged
gregmagolan merged 1 commit into
mainfrom
rules_js_2
May 22, 2024
Merged

feat: upgrade to rules_js 2.0#253
gregmagolan merged 1 commit into
mainfrom
rules_js_2

Conversation

@gregmagolan

@gregmagolan gregmagolan commented Apr 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)
  • Suggested release notes are provided below:

Test plan

  • Covered by existing test cases

@gregmagolan gregmagolan mentioned this pull request Apr 21, 2024
Closed
21 tasks
jbedard
jbedard reviewed Apr 21, 2024
View reviewed changes
Comment thread swc/private/swc.bzl
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 7 times, most recently from 38dcc78 to f813276 Compare April 22, 2024 01:08
This was referenced Apr 27, 2024
Merged
Merged
Merged
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 5 times, most recently from 8d7c80f to 40b90a6 Compare April 27, 2024 19:34
@gregmagolan gregmagolan mentioned this pull request Apr 27, 2024
Merged
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 5 times, most recently from c1ee0b0 to c0f077b Compare April 28, 2024 15:50
jbedard
jbedard reviewed Apr 29, 2024
View reviewed changes
Comment thread swc/defs.bzl
jbedard
jbedard reviewed Apr 29, 2024
View reviewed changes
Comment thread swc/dependencies.bzl
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 2 times, most recently from 1826541 to 3843ada Compare April 29, 2024 00:36
@gregmagolan gregmagolan marked this pull request as ready for review April 29, 2024 01:18
@gregmagolan gregmagolan requested a review from jbedard April 29, 2024 01:21
@gregmagolan gregmagolan mentioned this pull request May 2, 2024
Merged
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 2 times, most recently from abddcef to 8f52bf4 Compare May 8, 2024 21:40
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 10 times, most recently from c2a8fe6 to 5ea587a Compare May 15, 2024 04:26
@gregmagolan gregmagolan merged commit 82f08aa into main May 22, 2024
@gregmagolan gregmagolan deleted the rules_js_2 branch May 22, 2024 00:58
@alexeagle alexeagle mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedard jbedard Awaiting requested review from jbedard

1 more reviewer

@alexeagle alexeagle alexeagle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gregmagolan @alexeagle @jbedard