Skip to content

fix(pnpm): support npm: alias dependencies with pnpm lockfile v5#1767

Merged
jbedard merged 1 commit into
aspect-build:mainfrom
jbedard:pnpm-v5-aliases
May 29, 2024
Merged

fix(pnpm): support npm: alias dependencies with pnpm lockfile v5#1767
jbedard merged 1 commit into
aspect-build:mainfrom
jbedard:pnpm-v5-aliases

Conversation

@jbedard

@jbedard jbedard commented May 29, 2024

Copy link
Copy Markdown
Member

It's possible this bug has existed with lockfile v5 for quite some time, although I'm not certain.

--

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard requested a review from gregmagolan May 29, 2024 02:18
@jbedard jbedard force-pushed the pnpm-v5-aliases branch from 1c51a86 to 264f9a3 Compare May 29, 2024 02:20
@aspect-workflows

aspect-workflows Bot commented May 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Test

All tests were cache hits

193 tests (100.0%) were fully cached saving 53s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 693ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 923ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 520ms.

Test

e2e/pnpm_lockfiles

8 test targets passed

Targets 
//v54:repos_0_test [k8-fastbuild]445ms
//v54:targets [k8-fastbuild]87ms
//v60:repos_0_test [k8-fastbuild]556ms
//v60:targets [k8-fastbuild]120ms
//v61:repos_0_test [k8-fastbuild]680ms
//v61:targets [k8-fastbuild]96ms
//v90:repos_0_test [k8-fastbuild]627ms
//v90:targets [k8-fastbuild]106ms

Total test execution time was 3s. 13 tests (61.9%) were fully cached saving 5s.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 605ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.

Buildifier      Format

@jbedard jbedard mentioned this pull request May 29, 2024
Closed
gregmagolan
gregmagolan approved these changes May 29, 2024
View reviewed changes

@gregmagolan gregmagolan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard merged commit 21b6ee3 into aspect-build:main May 29, 2024
@jbedard jbedard deleted the pnpm-v5-aliases branch May 29, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbedard @gregmagolan