Skip to content

fixup! refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)#1695

Merged
jbedard merged 1 commit into
aspect-build:2.xfrom
jbedard:2.x-fixup
May 3, 2024
Merged

fixup! refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)#1695
jbedard merged 1 commit into
aspect-build:2.xfrom
jbedard:2.x-fixup

Conversation

@jbedard

@jbedard jbedard commented May 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

When you upgraded to 2.7.1 aspect_bazel_lib was removed as a direct dep of these so we shouldn't be invoking aspect_bazel_lib_dependencies anymore.

This is a !fixup on that commit, assuming we'll rebase/squash and push -f at some point still?

@jbedard jbedard requested a review from gregmagolan May 3, 2024 06:13
@aspect-workflows

aspect-workflows Bot commented May 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Test

All tests were cache hits

190 tests (100.0%) were fully cached saving 59s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 428ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 704ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 5s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 812ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 205ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 435ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

4 tests (100.0%) were fully cached saving 564ms.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 467ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 350ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 164ms.

Buildifier      Format

gregmagolan
gregmagolan reviewed May 3, 2024
View reviewed changes
Comment thread e2e/pnpm_workspace_deps/WORKSPACE
@gregmagolan

gregmagolan commented May 3, 2024

Copy link
Copy Markdown
Member

Yea, we can squash it with the commit on the 2.x stack that makes most sense. Maybe the one that introduces rules_js_toolchains?

@jbedard

jbedard commented May 3, 2024

Copy link
Copy Markdown
Member Author

This commit is marked as a fixup! on the commit that made it red so I think that's the one that it should be squashed into.

@jbedard jbedard merged commit 0973bbd into aspect-build:2.x May 3, 2024
@jbedard jbedard deleted the 2.x-fixup branch May 3, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbedard @gregmagolan