Skip to content

Conversation

@emilk
Copy link
Contributor

@emilk emilk commented Apr 11, 2022

cargo-deny is an amazing tool that protects from:

  • duplicated crates (code bloat)
  • copy-left licenses in the dependency tree
  • RUSTSEC advisories

…and more!

In this case I noticed that three-d brought in two copies of the image crate, which means a lot of extra code, which is in particularly worrisome when compiling to Wasm.

@emilk emilk marked this pull request as draft April 11, 2022 11:18
@emilk emilk marked this pull request as ready for review April 11, 2022 11:38
@asny
Copy link
Owner

asny commented Apr 12, 2022

I think you mentioned it earlier, at least I looked at it but didn't get any further. Looks really good! 👍

@asny asny merged commit 4cd766c into asny:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants