Fix jinja macro arguments handling#709
Merged
GuillaumeGomez merged 2 commits intoaskama-rs:mainfrom Mar 18, 2026
Merged
Conversation
c8a529c to
d18a732
Compare
Collaborator
Author
|
Ah, new nightly fmt changes. Updated locally and fixed formatting. |
5da3182 to
813116e
Compare
Kijewski
reviewed
Mar 18, 2026
Comment on lines
+121
to
+122
| // FIXME: Too many steps to get a string. Also, `visit_associated_item` returns | ||
| // stuff like `x.y`, how is this supposed to match a variable? O.o |
Member
There was a problem hiding this comment.
I had the same exact thought some time back, too, but then I was too lazy to refactor the code. :D
Collaborator
Author
There was a problem hiding this comment.
Hehehe. We'll get to it at some point.
I think we're getting close enough for a new major release once a few more things are merged. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #707.
I simplified the logic a bit by first storing all arguments value (their expr in short), and then loop through them to generate the bindings. Since pretty much all arguments "passing" validity is checked in
askama_parser, I could remove a lot of checks too.