Emit an error if an extends block doesn't come first in a template#584
Merged
GuillaumeGomez merged 2 commits intoaskama-rs:masterfrom Aug 25, 2025
Merged
Emit an error if an extends block doesn't come first in a template#584GuillaumeGomez merged 2 commits intoaskama-rs:masterfrom
GuillaumeGomez merged 2 commits intoaskama-rs:masterfrom
Conversation
999c21e to
c2e4718
Compare
c2e4718 to
b744cab
Compare
c61f164 to
52c4dfd
Compare
Member
|
I moved the test out of |
Kijewski
approved these changes
Aug 24, 2025
Member
Kijewski
left a comment
There was a problem hiding this comment.
Thanks!
Please review my change before merging. :)
Kijewski
reviewed
Aug 24, 2025
| let mut nb_nodes = 0; | ||
|
|
||
| repeat(0.., move |i: &mut _| Self::parse_nodes(i, &mut nb_nodes)) | ||
| .map(|v: Vec<_>| v) |
Member
There was a problem hiding this comment.
I don't remember why this "custom type ascription" was needed, but I'm happy that it isn't anymore!
Collaborator
Author
|
Your changes look good, thanks! :) As a follow-up, would be nice to add a regression test for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.