Skip to content

derive: un-inline Expr::Call handling for {{ expressions }} and remove parentheses#540

Merged
GuillaumeGomez merged 2 commits intoaskama-rs:masterfrom
Kijewski:pr-uninline-expr-call
Jul 24, 2025
Merged

derive: un-inline Expr::Call handling for {{ expressions }} and remove parentheses#540
GuillaumeGomez merged 2 commits intoaskama-rs:masterfrom
Kijewski:pr-uninline-expr-call

Conversation

@Kijewski
Copy link
Copy Markdown
Member

  • The call handling is by far the biggest part of the function.
  • Parentheses hurt automatic optimizations further down like compile-time escaping

The diff is best viewed with spaces hidden.

@Kijewski Kijewski added the derive Related to the code generating label Jul 24, 2025
@GuillaumeGomez
Copy link
Copy Markdown
Collaborator

Nice, thanks!

@GuillaumeGomez GuillaumeGomez merged commit 37ded31 into askama-rs:master Jul 24, 2025
42 checks passed
@Kijewski Kijewski deleted the pr-uninline-expr-call branch July 24, 2025 16:51
@Kijewski Kijewski mentioned this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

derive Related to the code generating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants