Implement #531: Allow named arguments in call expr macro invocations#533
Merged
GuillaumeGomez merged 3 commits intoaskama-rs:masterfrom Jul 22, 2025
Merged
Implement #531: Allow named arguments in call expr macro invocations#533GuillaumeGomez merged 3 commits intoaskama-rs:masterfrom
GuillaumeGomez merged 3 commits intoaskama-rs:masterfrom
Conversation
54ca80f to
7fca475
Compare
Contributor
Author
|
I think the CI failure is not caused by my changes(?) |
GuillaumeGomez
previously approved these changes
Jul 22, 2025
Collaborator
|
Changes look good to me, thanks! And yeah, this CI check fails from time to time. |
Kijewski
reviewed
Jul 22, 2025
Member
|
Thank you! And I really like your TDD-style commits! |
7fca475 to
48d5dba
Compare
Contributor
Author
|
Restored the trailing space
I'm somewhat torn. On the one hand, its the order I work in - on the other hand, it introduces a commit whose unit-tests fail 😅. But if you like it, I'm happy :) |
GuillaumeGomez
approved these changes
Jul 22, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Kijewski 's pointer in #531 (comment) was priceless. Thank you!
I thought I would have to add support for named arguments to the lexer of
Exprfirst...Turns out the change is actually quite easy.
Hint: It's probably easier to read commit by commit again
Fixes #531.