book: fix rust-docs on readthedocs#528
Merged
GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom Jul 14, 2025
Merged
Conversation
We want to use the nightly features `doc_cfg` and `doc_auto_cfg` when we build our documentation. Still, we want to use a stable compiler, e.g. to have stable links in our docs, so we opt in to the use of unstable features with the use of `RUSTC_BOOTSTRAP=1`. The problem is that `proc-macro2` only checks whether it can use any unstable features, not which unstable features, and it always assumes that you run the newest nightly rust version if the use of unstable features is possible. This PR disables the detection if unstable features are available to `proc-macro2` by pretending that we are in an early stage of a bootstrapped rustc build.
GuillaumeGomez
approved these changes
Jul 14, 2025
Collaborator
|
Weird fix but if it works... 😆 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to use the nightly features
doc_cfganddoc_auto_cfgwhen we build our documentation. Still, we want to use a stable compiler, e.g. to have stable links in our docs, so we opt in to the use of unstable features with the use ofRUSTC_BOOTSTRAP=1.The problem is that
proc-macro2only checks whether it can use any unstable features, not which unstable features, and it always assumes that you run the newest nightly rust version if the use of unstable features is possible.This PR disables the detection if unstable features are available to
proc-macro2by pretending that we are in an early stage of a bootstrapped rustc build.