Skip to content

Fix panic when using include in call block#516

Merged
Kijewski merged 2 commits intoaskama-rs:masterfrom
seijikun:mr-fix-508
Jul 4, 2025
Merged

Fix panic when using include in call block#516
Kijewski merged 2 commits intoaskama-rs:masterfrom
seijikun:mr-fix-508

Conversation

@seijikun
Copy link
Copy Markdown
Contributor

@seijikun seijikun commented Jul 4, 2025

The include's context was not available because find_used_templates was not scanning for includes inside call-blocks.

Fixes #508.

@GuillaumeGomez GuillaumeGomez changed the title Fix #508: using include in call block panics proc-macro using include in call block panics proc-macro Jul 4, 2025
@GuillaumeGomez
Copy link
Copy Markdown
Collaborator

Looks good to me, thanks!

By the way, instead of putting it in the PR title, you can add the "Fixes #XXX" part in your first comment. Like that, once merged, the related issues are closed.

@GuillaumeGomez GuillaumeGomez requested a review from Kijewski July 4, 2025 19:06
@pollend
Copy link
Copy Markdown
Contributor

pollend commented Jul 4, 2025

Oh, awesome. was planning on trying to tackle this.

Copy link
Copy Markdown
Member

@Kijewski Kijewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Kijewski Kijewski merged commit dc2d9f5 into askama-rs:master Jul 4, 2025
42 checks passed
@Kijewski Kijewski mentioned this pull request Jul 5, 2025
@GuillaumeGomez GuillaumeGomez changed the title using include in call block panics proc-macro Fix panic when using include in call block Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using include statement in call block causes Template proc-macro to panic

4 participants