Skip to content

parser: understand nested block comments in macro calls#504

Merged
GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom
Kijewski:6503980895371264
Jul 1, 2025
Merged

parser: understand nested block comments in macro calls#504
GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom
Kijewski:6503980895371264

Conversation

@Kijewski
Copy link
Copy Markdown
Member

@Kijewski Kijewski commented Jun 29, 2025

@Kijewski Kijewski added bug Something isn't working fuzzing error A bug found by fuzzing parser Related to the parser labels Jun 30, 2025
@Kijewski Kijewski requested a review from GuillaumeGomez July 1, 2025 16:06
@GuillaumeGomez
Copy link
Copy Markdown
Collaborator

Discovered that rust had inner block comments with this PR. ^^'

Thanks for the fix!

Comment thread askama_parser/src/expr.rs
@Kijewski
Copy link
Copy Markdown
Member Author

Kijewski commented Jul 1, 2025

Discovered that rust had inner block comments with this PR. ^^'

Hehe, I only learnt of it through this fuzzing error, too.

@GuillaumeGomez GuillaumeGomez merged commit a3f913a into askama-rs:master Jul 1, 2025
42 checks passed
@Kijewski Kijewski deleted the 6503980895371264 branch July 1, 2025 17:05
@Kijewski Kijewski mentioned this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fuzzing error A bug found by fuzzing parser Related to the parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants