parser: introduce more types for Expr variants#498
Merged
Kijewski merged 4 commits intoaskama-rs:masterfrom Jun 24, 2025
Merged
parser: introduce more types for Expr variants#498Kijewski merged 4 commits intoaskama-rs:masterfrom
Expr variants#498Kijewski merged 4 commits intoaskama-rs:masterfrom
Conversation
566d9e7 to
82578fb
Compare
| Option<Box<WithSpan<'a, Expr<'a>>>>, | ||
| ), | ||
| BinOp(Box<BinOp<'a>>), | ||
| Range(Box<Range<'a>>), |
Collaborator
There was a problem hiding this comment.
We can add a const assert on Expr's size to keep an eye on how it goes if you want?
GuillaumeGomez
approved these changes
Jun 24, 2025
Collaborator
|
It's a good idea, thanks! Feel free to merge with or without the const assert (I can add it in a follow-up PR 😉). |
Member
Author
|
Yes, good idea. At least it should not get bigger than it is now, I guess. :) |
This was referenced Jun 24, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the code prettier and
Exprsmaller.