parser: reject illegal raw identifiers in attribute access & ensure valid paths in generics#497
Merged
Kijewski merged 3 commits intoaskama-rs:masterfrom Jun 23, 2025
Merged
Conversation
| } | ||
| Ok(()) | ||
| } | ||
| Expr::Attr(elem, attr) => { |
Collaborator
There was a problem hiding this comment.
We should really rename this variant into something like Field(Access?).
Member
Author
There was a problem hiding this comment.
Hm, I don't know. It does not have to be a field, e.g. in {{ self.attr() }} the attribute field of self is accessed, which might be a field, a method, or a field accessed through deref.
But "attr" normally means #[attr], so "field" might still be the better term.
Collaborator
There was a problem hiding this comment.
AssociatedItem then. 😄
GuillaumeGomez
approved these changes
Jun 23, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the parser reject illegal raw identifiers as in:
{{ crate.4 }} {{ foo::<bar::crate> }}Resolves issue https://issues.oss-fuzz.com/issues/426835840.