parser: implement {% raw %} and Lit::parse() without skip_till#489
Merged
GuillaumeGomez merged 3 commits intoaskama-rs:masterfrom Jun 17, 2025
Merged
parser: implement {% raw %} and Lit::parse() without skip_till#489GuillaumeGomez merged 3 commits intoaskama-rs:masterfrom
{% raw %} and Lit::parse() without skip_till#489GuillaumeGomez merged 3 commits intoaskama-rs:masterfrom
Conversation
The implementation is longer than before, but also more correct:
Before, the input `{% raw %}{% endraw }}{% endraw %}` would be a syntax
error, now it renders the string `{% endraw }}`.
{% raw %} without skip_till{% raw %} and Lit::parse() without skip_till
GuillaumeGomez
approved these changes
Jun 17, 2025
Collaborator
|
One less dependency, yeay! \o/ |
Member
Author
|
The dependency is still there, just transitively now. :) I had a look: Our implementation was needed with nom, only winnow made it possible to scan for multiple literals in |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation is longer than before, but also more correct: Before, the input
{% raw %}{% endraw }}{% endraw %}would be a syntax error, now it renders the string{% endraw }}.