parser: simplify {# comment #} parsing#488
Merged
Kijewski merged 1 commit intoaskama-rs:masterfrom Jun 16, 2025
Merged
Conversation
Kijewski
commented
Jun 16, 2025
Comment on lines
+66
to
+91
| --> <source attribute>:1:0 | ||
| "{# comment" | ||
| --> tests/ui/unclosed-nodes.rs:36:21 | ||
| | | ||
| 36 | #[template(source = "{# comment", ext = "txt")] | ||
| | ^^^^^^^^^^^^ | ||
|
|
||
| error: unclosed comment, missing "#}" | ||
| --> <source attribute>:1:2 | ||
| " comment " | ||
| --> <source attribute>:1:0 | ||
| "{# comment " | ||
| --> tests/ui/unclosed-nodes.rs:40:21 | ||
| | | ||
| 40 | #[template(source = "{# comment ", ext = "txt")] | ||
| | ^^^^^^^^^^^^^ | ||
|
|
||
| error: unclosed comment, missing "#}" | ||
| --> <source attribute>:1:2 | ||
| " comment -" | ||
| --> <source attribute>:1:0 | ||
| "{# comment -" | ||
| --> tests/ui/unclosed-nodes.rs:44:21 | ||
| | | ||
| 44 | #[template(source = "{# comment -", ext = "txt")] | ||
| | ^^^^^^^^^^^^^^ | ||
|
|
||
| error: unclosed comment, missing "#}" | ||
| --> <source attribute>:1:2 | ||
| " comment -#" | ||
| --> <source attribute>:1:0 | ||
| "{# comment -#" |
Member
Author
There was a problem hiding this comment.
I think the span is more correct this way.
Collaborator
There was a problem hiding this comment.
Indeed, at least if it's a big file it'll not take the whole remaining content. :)
`winnow`'s `take_until` with feature `simd` enabled is implemented like our "optimized" `skip_till`. There is no need to reinvent the wheel.
GuillaumeGomez
approved these changes
Jun 16, 2025
Collaborator
|
Nice cleanup, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
winnow'stake_untilwith featuresimdenabled is implemented like our "optimized"skip_till. There is no need to reinvent the wheel.I intend to remove our home-grown
skip_till/memchr_splitter.rsin subsequent PRs.