Filters linebreaks, paragraphbreaks and linebreaksbr only need core#486
Merged
GuillaumeGomez merged 4 commits intoaskama-rs:masterfrom Jun 17, 2025
Merged
Filters linebreaks, paragraphbreaks and linebreaksbr only need core#486GuillaumeGomez merged 4 commits intoaskama-rs:masterfrom
linebreaks, paragraphbreaks and linebreaksbr only need core#486GuillaumeGomez merged 4 commits intoaskama-rs:masterfrom
Conversation
linebreaks in corelinebreaks, paragraphbreaks and linebreaksbr only need core
6 tasks
Kijewski
commented
Jun 14, 2025
Comment on lines
+306
to
+307
| <P>HELLO &#38;</P><P>GOODBYE!</P> | ||
| <P>HELLO &#38;</P><P>GOODBYE!</P>] |
Member
Author
There was a problem hiding this comment.
The old output was wrong, IMHO. The extra '\n' did not match the description.
| let (has_eol, line) = strip_newline_suffix(line); | ||
| self.0.write_str(line)?; | ||
| if has_eol { | ||
| self.0.write_str("<br/>")?; |
Collaborator
There was a problem hiding this comment.
Suggested change
| self.0.write_str("<br/>")?; | |
| self.0.write_str("<br>")?; |
Member
Author
|
I added the Omitting the The current implementation would work in XML formats like RSS or ATOM, too. Without it closing the |
Member
Author
|
@GuillaumeGomez, so, are you OK with keeping the |
Collaborator
|
I don't mind. |
GuillaumeGomez
approved these changes
Jun 17, 2025
Collaborator
|
Thanks! |
Member
Author
|
Thank you for reviewing! :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.