Skip to content

parser: reject illegal string literals#479

Merged
GuillaumeGomez merged 3 commits intoaskama-rs:masterfrom
Kijewski:issue-425
Jun 10, 2025
Merged

parser: reject illegal string literals#479
GuillaumeGomez merged 3 commits intoaskama-rs:masterfrom
Kijewski:issue-425

Conversation

@Kijewski
Copy link
Copy Markdown
Member

@Kijewski Kijewski commented Jun 9, 2025

Comment thread askama_derive/src/tests.rs Dismissed
Comment thread askama_derive/src/tests.rs Dismissed
Comment thread askama_parser/src/expr.rs Outdated
Copy link
Copy Markdown
Collaborator

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit but otherwise looks good to me, nice work!

@Kijewski Kijewski force-pushed the issue-425 branch 2 times, most recently from 3a542a6 to 887bb03 Compare June 9, 2025 17:09
@Kijewski
Copy link
Copy Markdown
Member Author

Kijewski commented Jun 9, 2025

Thanks! There were many rules not followed. I wonder why this was not a problem before.

I added another commit to the PR to generate better byte code in punctuation(). We can use the fact that we don't care what punctuation was found, only that some punctuation was found.

@GuillaumeGomez
Copy link
Copy Markdown
Collaborator

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 9309aca into askama-rs:master Jun 10, 2025
42 checks passed
@Kijewski Kijewski deleted the issue-425 branch June 10, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parser: cstring literals must not contain NUL bytes

3 participants