parser: macro calls need proper tokens#468
Merged
Kijewski merged 2 commits intoaskama-rs:masterfrom Jun 1, 2025
Merged
Conversation
With this PR invalid tokens inside a macro call `macro_name!(..)` are rejected. Otherwise we might emit invalid code that cannot be parsed by rust.
| } | ||
|
|
||
| #[test] | ||
| #[rustfmt::skip] // FIXME: rustfmt bug <https://github.com/rust-lang/rustfmt/issues/6565> |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test
GuillaumeGomez
approved these changes
Jun 1, 2025
Collaborator
|
Looks all good to me, thanks! |
Member
Author
|
I'm happy to see what more fuzzing errors will be found. :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR invalid tokens inside a macro call
macro_name!(..)are rejected. Otherwise we might emit invalid code that cannot be parsed by rust. Also update fuzzing corpus to include derive.Resolves #459.
Resolves https://issues.oss-fuzz.com/issues/418896502.