Add support for mutable variables#462
Merged
Kijewski merged 3 commits intoaskama-rs:masterfrom Jun 1, 2025
Merged
Conversation
4b27564 to
007a1d6
Compare
Member
|
I think we should track if a variable was allocated with |
Collaborator
Author
|
Hum... I wonder if we shouldn't just keep the shadowing. If the new variable doesn't have the same type, it would fail compilation after all. Shadowing and updating the variable value are kinda the same no? |
Member
|
Yeah, makes sense. Also that keeps it simple, and I guess I don't really see a dire need for re-assignable variables. |
Kijewski
approved these changes
Jun 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #452.
For now it only supports variables declared as mutable, not destructuring. Not sure if we want to go down this road or not but if we do, let's do it in a follow-up PR.