Update ref documentation#456
Merged
GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom May 26, 2025
Merged
Conversation
Add a line about `ref` renaming to the upgrade guide
Contributor
Author
|
This is outside the scope of this PR, but I think it would be beneficial to keep // filters.rs:45
"as_ref" => {
eprintln!(
"Warning: `as_ref` is deprecated and has been renamed to `ref`. Please update your templates."
);
Self::visit_ref_filter
}That said, printing to stderr isn’t ideal. It would be great to emit proper deprecation warnings directly in the template output, for example: However, implementing this kind of contextual warning would likely require some changes to the current code 😑 |
GuillaumeGomez
approved these changes
May 26, 2025
Collaborator
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
as_refin the book torefAdd a line about
refrenaming to the upgrade guide