book: upgrading: complete note about filter change#453
Merged
Kijewski merged 1 commit intoaskama-rs:masterfrom May 22, 2025
Merged
book: upgrading: complete note about filter change#453Kijewski merged 1 commit intoaskama-rs:masterfrom
Kijewski merged 1 commit intoaskama-rs:masterfrom
Conversation
commit c6d45e1 ("Always supply `values` to custom filters") added a second mandatory argument, and it was not obvious what broke on upgrade through the current explanation so write a bit more about it.
GuillaumeGomez
approved these changes
May 22, 2025
Collaborator
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit c6d45e1 ("Always supply
valuesto custom filters") added a second mandatory argument, and it was not obvious what broke on upgrade through the current explanation so write a bit more about it.tested the link by fiddling with https://askama.readthedocs.io/en/latest/upgrading.html in the inspector
Thanks for askama!