Prevent crate to be used as identifier#450
Merged
GuillaumeGomez merged 5 commits intoaskama-rs:masterfrom May 20, 2025
Merged
Conversation
Kijewski
reviewed
May 20, 2025
Kijewski
reviewed
May 20, 2025
Member
|
Please add the found fuzzing failure, too: #[test]
fn invalid_raw_identifier_crate() -> Result<(), syn::Error> {
let input = quote! {
#[template(
ext = "",
source = "{{\u{c}KK3e331<c7}}61/63m3333u7<c0.}}\u{6}\0\u{c}\u{c}{{c/crate<338<c7}}6unsafe/63a3ae\u{c}\u{c}\u{c}%et"
)]
struct ffffn {}
};
let output = derive_template(input, import_askama);
let _: syn::File = syn::parse2(output)?;
Ok(())
} |
5664952 to
5829cea
Compare
Kijewski
reviewed
May 20, 2025
5829cea to
9911191
Compare
9911191 to
5099820
Compare
Collaborator
Author
|
I think I covered all cases. :) |
Member
|
Good idea to make this a problem of the parser, not the code generator! I just noticed the |
Collaborator
Author
|
Nice catch! (and thanks for the bugfix!) Your changes look good to me. =D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #449.