Print invalid generated code during panic#446
Merged
GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom May 19, 2025
Merged
Print invalid generated code during panic#446GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom
GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom
Conversation
f9f86b6 to
f4aa0ce
Compare
Collaborator
|
Please add a UI test. :) |
Collaborator
|
Oh wait, might be tricky to do that. Hum... Is there a way to add such a test? |
Member
Author
|
I don't think so. Any input that would cause the panic, so it can be caught in a UI test, would be a bug that needs to be fixed. |
GuillaumeGomez
approved these changes
May 19, 2025
Collaborator
|
Yeah that's what I figured out. Unless we voluntarily add a failing case in our code generator, not possible. Don't think it's worth it so nothing more we can do here. Very good idea, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.