derive: prefix more generated variables with __askama#444
Merged
Kijewski merged 4 commits intoaskama-rs:masterfrom May 18, 2025
Merged
derive: prefix more generated variables with __askama#444Kijewski merged 4 commits intoaskama-rs:masterfrom
__askama#444Kijewski merged 4 commits intoaskama-rs:masterfrom
Conversation
GuillaumeGomez
approved these changes
May 18, 2025
Collaborator
|
Looks like a good idea! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to say "prefix all generated variables with
__askama", but I'm sure I overlooked some variables. :)Rationale: We deny defining variables with this naming scheme, so this change makes sure that the user does not accidentally shadow a generated variable.
Squash before merging.