Relax Sized constraint on impl FastWritable for Cow#432
Relax Sized constraint on impl FastWritable for Cow#432Kijewski merged 5 commits intoaskama-rs:masterfrom
impl FastWritable for Cow#432Conversation
|
Please add test to ensure it works as expected. Then seems all good to me. |
|
I added a test, but for me the test-suite is currently in a failing state? Is that state expected? Also for some reason escaping is broken? (see todo in the added "test") Edit: The error messages have slightly more information for me it seems. in master vs for me. Edit2: |
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
| // If it didn't, compiling the tests would fail. | ||
| // | ||
| // Since this test fails at compile-time, there isn't actually any need to run it. | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
| #[allow(dead_code)] | |
| #[test] |
There was a problem hiding this comment.
The test works compile time though. I could even just put it in a const block.
There was a problem hiding this comment.
True, however it also allows us to ensure that it's actually built.
There was a problem hiding this comment.
Why would the test not be built?
With cargo test --workspace it's built.
Co-authored-by: René Kijewski <Kijewski@users.noreply.github.com>
|
Thank you for the better test code |
Fixes: #431
Please note, that I have not actually tested this commit.
This should however address the issue.