Fix unique filter implementation#417
Conversation
Kijewski
left a comment
There was a problem hiding this comment.
#[cfg(feature = "code-in-doc")] { is needed for tests that use ```jinja block
|
Why using |
|
Because we had no filter tests whatsoever, and when they were added, they were added using this format. |
|
Do you mind if I migrate them to |
|
Yes, I do. The problem is not even related to |
|
My issue with the current doctests is that they require a feature to run, which is not great. I won't force if you prefer it this way but I'd rather having them run all the time if we run tests, even if the |
|
Just to confirm: do you want to keep them like this before I make the change? 😄 |
Yes, I want to keep them as they are. IMHO it's much more readable docs like this, without the mental overhead of counting backslashes |
|
A debate for another day then. Reverting these changes then! |
17826c5 to
69acafa
Compare
|
Removed other changes. |
I also removed the "code-in-doc"
cfgfrom doctests to be sure that they are run all the time.Also fixed the wrong implementation of the
uniquefilter (it was supposed to return aResult).