Skip to content

Move FastWritable into askama root#411

Merged
Kijewski merged 1 commit intoaskama-rs:masterfrom
GuillaumeGomez:move-fastwritable
Apr 22, 2025
Merged

Move FastWritable into askama root#411
Kijewski merged 1 commit intoaskama-rs:masterfrom
GuillaumeGomez:move-fastwritable

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Collaborator

Fixes #409.

@GuillaumeGomez GuillaumeGomez requested a review from Kijewski April 20, 2025 10:16
@Kijewski Kijewski added this to the askama v0.14.0 milestone Apr 20, 2025
@Kijewski
Copy link
Copy Markdown
Member

Thanks for implementing the move! The link in the book needs to be updated, too:

[`FastWritable`]: <./doc/askama/filters/trait.FastWritable.html>

@GuillaumeGomez
Copy link
Copy Markdown
Collaborator Author

Ah, I didn't have it initially. Now I do after a rebase. Good catch!

@Kijewski
Copy link
Copy Markdown
Member

This line ↓ needs to be updated, too.

Gotta say, I like mdbook's {{#include …}} feature. I wish I knew about it before. Having checked examples is great.

@GuillaumeGomez
Copy link
Copy Markdown
Collaborator Author

yeah it's pretty great. :)

@GuillaumeGomez
Copy link
Copy Markdown
Collaborator Author

Fixed the import I missed.

@GuillaumeGomez GuillaumeGomez force-pushed the move-fastwritable branch 2 times, most recently from 5326c51 to 6a94f28 Compare April 21, 2025 21:54
Copy link
Copy Markdown
Member

@Kijewski Kijewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kijewski Kijewski merged commit 6f912ab into askama-rs:master Apr 22, 2025
41 checks passed
@GuillaumeGomez GuillaumeGomez deleted the move-fastwritable branch April 22, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose FastWritable in askama's root

2 participants