Update to more current rust version on readthedocs#410
Merged
GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom Apr 20, 2025
Merged
Update to more current rust version on readthedocs#410GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom
GuillaumeGomez merged 1 commit intoaskama-rs:masterfrom
Conversation
Our documentation needs nightly features `doc_cfg`, `doc_auto_cfg` to build. Instead of using the nightly channel, which is not available on readthedocs.org, we opt in to nightly features by setting the environment variable `RUSTC_BOOTSTRAP` to `1`. This gives on unstable features in a stable channel. Our dependency `proc-macro2` tests if opting-in to unstable feature is possible, and if so, it expects that it runs on a quite recent `nightly` release. The newest rust version that is available out-of-the-box on readthedocs is rust 1.82, which is not *that* recent anymore, being released on 2024-08-30. This PR makes use of the readly configured tool `asdf` to select a more recent rust version semi-manually.
GuillaumeGomez
approved these changes
Apr 20, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, our documentation fails to build on readthedocs, see e.g. https://app.readthedocs.org/projects/askama/builds/27887854/
Our documentation needs nightly features
doc_cfg,doc_auto_cfgto build. Instead of using the nightly channel, which is not available on readthedocs.org, we opt in to nightly features by setting the environment variableRUSTC_BOOTSTRAPto1. This gives on unstable features in a stable channel.Our dependency
proc-macro2tests if opting-in to unstable feature is possible, and if so, it expects that it runs on a quite recentnightlyrelease. The newest rust version that is available out-of-the-box on readthedocs is rust 1.82, which is not that recent anymore, being released on 2024-08-30.This PR makes use of the readly configured tool
asdfto select a more recent rust version semi-manually.