Implement first and blank arguments for |indent#401
Merged
Kijewski merged 2 commits intoaskama-rs:masterfrom Apr 17, 2025
Merged
Implement first and blank arguments for |indent#401Kijewski merged 2 commits intoaskama-rs:masterfrom
first and blank arguments for |indent#401Kijewski merged 2 commits intoaskama-rs:masterfrom
Conversation
7d78cc4 to
74030c9
Compare
Collaborator
|
Gonna wait for #397 to be merged before reviewing this one. 😉 |
Member
Author
|
Rebased. |
| fn as_indent(&self) -> &str; | ||
| } | ||
|
|
||
| impl AsIndent for str { |
Collaborator
There was a problem hiding this comment.
CowStr I suppose too?
Member
Author
There was a problem hiding this comment.
Cow<'_, T> is implemented further down.
| assert_eq!( | ||
| indent("hello\n\n bar", 4, true, true).unwrap().to_string(), | ||
| " hello\n \n bar" | ||
| ); |
Collaborator
There was a problem hiding this comment.
Can you add test with string prefixes and basically all supported types in a separate test please?
Collaborator
|
As a follow-up we could also allow to have named arguments in |
GuillaumeGomez
approved these changes
Apr 17, 2025
Collaborator
|
Looks good to me, thanks! |
Member
Author
Yes, for the filter |
Collaborator
|
Agreed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For feature parity with Jinja: https://jinja.palletsprojects.com/en/stable/templates/#jinja-filters.indent
Resolves #193.